From bf386250141f18f61321bc4b9a56c7b67c0b1668 Mon Sep 17 00:00:00 2001 From: Norman Yu Date: Thu, 15 Sep 2022 18:10:19 +0800 Subject: [PATCH] Fix bug in RNN where hprev always referred to start. Change so that hprev refers to output of previous cell --- makemore.py | 1 + 1 file changed, 1 insertion(+) diff --git a/makemore.py b/makemore.py index ed0440e..db0fe4c 100644 --- a/makemore.py +++ b/makemore.py @@ -330,6 +330,7 @@ class RNN(nn.Module): for i in range(t): xt = emb[:, i, :] # (b, n_embd) ht = self.cell(xt, hprev) # (b, n_embd2) + hprev = ht hiddens.append(ht) # decode the outputs