Merge pull request #3 from normanyu/fix-rnn-prev-state

Fix bug in RNN where hprev always referred to start.
2022-09-15 08:26:41 -07:00 · 2022-09-15 08:26:41 -07:00 · f61811b994
parent 2f5e8d746e bf38625014
commit f61811b994
1 changed files with 1 additions and 0 deletions
--- a/makemore.py
+++ b/makemore.py
@ -330,6 +330,7 @@ class RNN(nn.Module):
        for i in range(t):
            xt = emb[:, i, :] # (b, n_embd)
            ht = self.cell(xt, hprev) # (b, n_embd2)
+            hprev = ht
            hiddens.append(ht)

        # decode the outputs